Source file value_stream.ml

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
open! Core

type 'a t =
  | Simple of 'a Sequence.t
  | Interleaved of 'a Sequence.t list

module type Sexpable_comparable = sig
  type t [@@deriving compare, sexp_of]

  include Comparable.S_plain with type t := t
end

let test
  (type a)
  (module M : Sexpable_comparable with type t = a)
  ~(actual : a Sequence.t)
  ~(expected : a t)
  ~cutoff
  : [ `Ok | `Error of Error.t | `Inconclusive ]
  =
  match expected with
  | Simple expected ->
    let actual_bounded = Sequence.length_is_bounded_by actual ~max:cutoff in
    let expected_bounded = Sequence.length_is_bounded_by expected ~max:cutoff in
    let clip x = Sequence.take x cutoff |> Sequence.to_list in
    let actual_clipped, expected_clipped = clip actual, clip expected in
    if not ([%equal: M.t list] actual_clipped expected_clipped)
    then
      `Error
        (Error.create_s
           [%message
             "Sequences not equal"
               (actual_clipped : M.t list)
               (expected_clipped : M.t list)])
    else if actual_bounded && expected_bounded
    then `Ok
    else `Inconclusive
  | Interleaved expected ->
    let actual_bounded = Sequence.length_is_bounded_by actual ~max:cutoff in
    let expected_bounded =
      Sequence.length_is_bounded_by (Sequence.concat_list expected) ~max:cutoff
    in
    let clip x = Sequence.take x cutoff |> Sequence.to_list in
    let actual_clipped = clip actual in
    let expected_clipped = List.map expected ~f:clip in
    let first_parse_check =
      match actual_clipped with
      | [] -> Ok `First_agrees
      | v :: _ ->
        if List.exists expected_clipped ~f:(fun expected ->
             [%compare.equal: M.t option] (Some v) (List.hd expected))
        then Ok `First_agrees
        else
          Or_error.error_s
            [%message "The first parse is nowhere to be found in expected parses"]
    in
    let set_check =
      let actual_set = M.Set.of_list actual_clipped in
      let expected_set = M.Set.of_list (List.concat expected_clipped) in
      match actual_bounded, expected_bounded with
      | true, true ->
        (* Both bounded: full set equality *)
        if [%compare.equal: M.Set.t] actual_set expected_set
        then Ok `Sets_equal
        else Or_error.error_s [%message "The parse sets disagree"]
      | false, false ->
        (* Both unbounded: cannot fully verify *)
        Ok `Cannot_verify
      | true, false ->
        (* Actual bounded, expected unbounded: length mismatch *)
        Or_error.error_s
          [%message "Length mismatch: actual is finite but expected is not"]
      | false, true ->
        (* Actual unbounded, expected bounded: length mismatch *)
        Or_error.error_s
          [%message "Length mismatch: actual is infinite but expected is not"]
    in
    (match first_parse_check, set_check with
     | Ok `First_agrees, Ok `Sets_equal -> `Ok
     | Ok `First_agrees, Ok `Cannot_verify -> `Inconclusive
     | Error e1, Error e2 -> `Error (Error.of_list [ e1; e2 ])
     | Error e, Ok _ | Ok _, Error e -> `Error e)
;;

module _ = struct
  module Int_comparable = struct
    include Int
    include functor Comparable.Make_plain
  end

  let%expect_test "Simple - matching sequences" =
    let actual = Sequence.of_list [ 1; 2; 3 ] in
    let expected = Simple (Sequence.of_list [ 1; 2; 3 ]) in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| Ok |}]
  ;;

  let%expect_test "Simple - non-matching sequences" =
    let actual = Sequence.of_list [ 1; 2; 3 ] in
    let expected = Simple (Sequence.of_list [ 1; 2; 4 ]) in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect
      {|
      (Error
       ("Sequences not equal" (actual_clipped (1 2 3)) (expected_clipped (1 2 4))))
      |}]
  ;;

  let%expect_test "Simple - empty sequences" =
    let actual = Sequence.empty in
    let expected = Simple Sequence.empty in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| Ok |}]
  ;;

  let%expect_test "Simple - respects cutoff, returns Inconclusive if unbounded" =
    let actual = Sequence.of_list [ 1; 2; 3; 4; 5 ] in
    let expected = Simple (Sequence.of_list [ 1; 2; 3; 9; 9 ]) in
    (* With cutoff=3, only first 3 elements are compared; prefixes match but both exceed
       cutoff so we get Inconclusive *)
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:3 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| Inconclusive |}]
  ;;

  let%expect_test "Simple - infinite sequences with matching prefix" =
    let actual = Sequence.cycle_list_exn [ 1; 2; 3 ] in
    let expected = Simple (Sequence.cycle_list_exn [ 1; 2; 3 ]) in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| Inconclusive |}]
  ;;

  let%expect_test "Simple - infinite sequences with non-matching prefix" =
    let actual = Sequence.cycle_list_exn [ 1; 2; 3 ] in
    let expected = Simple (Sequence.cycle_list_exn [ 1; 2; 4 ]) in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect
      {|
      (Error
       ("Sequences not equal"
        (actual_clipped
         (1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1
          2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2
          3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1 2 3 1))
        (expected_clipped
         (1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1
          2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2
          4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1 2 4 1))))
      |}]
  ;;

  let%expect_test "Interleaved - matching sets and first parse" =
    let actual = Sequence.of_list [ 1; 2; 3 ] in
    let expected = Interleaved [ Sequence.of_list [ 1; 2 ]; Sequence.of_list [ 3 ] ] in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| Ok |}]
  ;;

  let%expect_test "Interleaved - first parse not in expected firsts" =
    (* actual first is 2, but expected firsts are 1 and 3; sets still match *)
    let actual = Sequence.of_list [ 2; 1; 3 ] in
    let expected = Interleaved [ Sequence.of_list [ 1; 2 ]; Sequence.of_list [ 3 ] ] in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| (Error "The first parse is nowhere to be found in expected parses") |}]
  ;;

  let%expect_test "Interleaved - sets disagree" =
    let actual = Sequence.of_list [ 1; 2; 3 ] in
    let expected = Interleaved [ Sequence.of_list [ 1; 2 ]; Sequence.of_list [ 4 ] ] in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| (Error "The parse sets disagree") |}]
  ;;

  let%expect_test "Interleaved - empty actual, empty expected" =
    let actual = Sequence.empty in
    let expected = Interleaved [ Sequence.empty; Sequence.empty ] in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| Ok |}]
  ;;

  let%expect_test "Interleaved - empty actual, non-empty expected" =
    let actual = Sequence.empty in
    let expected = Interleaved [ Sequence.of_list [ 1 ] ] in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| (Error "The parse sets disagree") |}]
  ;;

  let%expect_test "Interleaved - both infinite, first parse agrees" =
    let actual = Sequence.cycle_list_exn [ 1; 2; 3 ] in
    let expected = Interleaved [ Sequence.cycle_list_exn [ 1; 2; 3 ] ] in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| Inconclusive |}]
  ;;

  let%expect_test "Interleaved - both infinite, first parse disagrees" =
    (* actual starts with 9, which is not first of any expected stream *)
    let actual =
      Sequence.append (Sequence.singleton 9) (Sequence.cycle_list_exn [ 1; 2 ])
    in
    let expected = Interleaved [ Sequence.cycle_list_exn [ 1; 2; 9 ] ] in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| (Error "The first parse is nowhere to be found in expected parses") |}]
  ;;

  let%expect_test "Interleaved - infinite actual, finite expected (length mismatch)" =
    let actual = Sequence.cycle_list_exn [ 1; 2; 3 ] in
    let expected = Interleaved [ Sequence.of_list [ 1; 2; 3 ] ] in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| (Error "Length mismatch: actual is infinite but expected is not") |}]
  ;;

  let%expect_test "Interleaved - finite actual, infinite expected (length mismatch)" =
    let actual = Sequence.of_list [ 1; 2; 3 ] in
    let expected = Interleaved [ Sequence.cycle_list_exn [ 1; 2; 3 ] ] in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| (Error "Length mismatch: actual is finite but expected is not") |}]
  ;;

  let%expect_test "Interleaved - respects cutoff for boundedness check" =
    (* With cutoff=5, sequences of length 3 are bounded *)
    let actual = Sequence.of_list [ 1; 2; 3 ] in
    let expected = Interleaved [ Sequence.of_list [ 1; 2; 3 ] ] in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:5 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect {| Ok |}]
  ;;

  let%expect_test "Interleaved - both checks fail reports both errors" =
    (* first is 9 (not in expected firsts), and 9 not in expected set *)
    let actual = Sequence.of_list [ 9 ] in
    let expected = Interleaved [ Sequence.of_list [ 1 ]; Sequence.of_list [ 2 ] ] in
    let result = test (module Int_comparable) ~actual ~expected ~cutoff:100 in
    print_s [%sexp (result : [ `Ok | `Error of Error.t | `Inconclusive ])];
    [%expect
      {|
      (Error
       ("The first parse is nowhere to be found in expected parses"
        "The parse sets disagree"))
      |}]
  ;;
end